get-balance and get-all-events migrated to v5 #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
approved these changes
Dec 12, 2024
arcoraven
pushed a commit
that referenced
this pull request
Dec 31, 2024
Signed-off-by: Phillip Ho <arcoraven@gmail.com>
arcoraven
added a commit
that referenced
this pull request
Dec 31, 2024
* regenerate sdk (#808) Co-authored-by: Phillip Ho <arcoraven@gmail.com> Signed-off-by: Phillip Ho <arcoraven@gmail.com> * bump sdk version (#813) Signed-off-by: Phillip Ho <arcoraven@gmail.com> * update workflow action versions (#812) Signed-off-by: Phillip Ho <arcoraven@gmail.com> * fix all biome errors (#815) * bump yarn to berry * fix all biome errors * bring back pinned resolved deps, fix whitepsace --------- Co-authored-by: Phillip Ho <arcoraven@gmail.com> Signed-off-by: Phillip Ho <arcoraven@gmail.com> * get-balance and get-all-events migrated to v5 (#816) Signed-off-by: Phillip Ho <arcoraven@gmail.com> * thirdweb version bump (#818) thirdweb sdk version bump to v5.78.0 Signed-off-by: Phillip Ho <arcoraven@gmail.com> * chore: fix some typos in comment Signed-off-by: toofooboo <cmaker@foxmail.com> Signed-off-by: Phillip Ho <arcoraven@gmail.com> --------- Signed-off-by: Phillip Ho <arcoraven@gmail.com> Signed-off-by: toofooboo <cmaker@foxmail.com> Co-authored-by: Nicholas St. Germain <nick@cajun.pro> Co-authored-by: Nischit Prasad Nhuchhe Pradhan <nischitpra@gmail.com> Co-authored-by: toofooboo <cmaker@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on migrating the wallet and contract event functionalities from version 4 to version 5 of the
thirdwebSDK, ensuring backward compatibility and implementing new methods for fetching wallet balances and contract events.Detailed summary
getSdkwiththirdwebClientand updated balance fetching inget-balance.ts.ContractEventV4andContractEventV5inevent.tsfor event handling.toContractEventV4Schemafunction for backward compatibility.get-all-events.tsto usegetContractEventsand map toContractEventV4.migrationV5.test.ts.